List endpoints lacked consistent pagination support. Several queries had no pagination parameters, and handlers used hardcoded limits.

Changes

SQL Queries

• Added LIMIT/OFFSET to GetAllProjects, GetSharedUsersForDefinition, GetSharedUsersForInstance
• Regenerated Go code via sqlc generate

Request Models

• Added limit (default: 100, max: 200) and offset (default: 0) to:
  • GetDefinitionSharedUsersRequest
  • GetInstanceSharedUsersRequest

Handler Functions

• Replaced hardcoded Limit: 999 with appropriate pagination:
  • User-facing endpoints: use input.Limit/input.Offset from request
  • Internal auth checks: use maxSharedUsersPerQuery constant (1000)
  • Admin operations: use maxAdminQueryLimit constant (999999)

Example

// Before: Hardcoded limit
instances, err := queries.GetAccessibleInstancesByUser(ctx, database.GetAccessibleInstancesByUserParams{
    Owner:  input.UserHandle,
    Limit:  999,  // Hardcoded
    Offset: 0,
})

// After: User-controlled pagination
instances, err := queries.GetAccessibleInstancesByUser(ctx, database.GetAccessibleInstancesByUserParams{
    Owner:  input.UserHandle,
    Limit:  int32(input.Limit),   // From request
    Offset: int32(input.Offset),
})

Pattern

User-facing list endpoints now accept query parameters. Internal operations use named constants to maintain correct authorization semantics.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.